Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address issues destroying VPC with Terraform #182

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Address issues destroying VPC with Terraform #182

merged 1 commit into from
Mar 29, 2022

Conversation

tpdownes
Copy link
Member

Address Terraform destroy issues by advising manual deletion of resources with links to the Google Cloud Console.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

* add guidance on identifying resources to delete
* link to Cloud Console to manually delete VMs and Firewall rules
Copy link
Contributor

@mittz mittz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Tom for making the simpler and clearer solution note to address the issue without risks by terraform import. LGTM!

@tpdownes tpdownes merged commit 0794bdd into GoogleCloudPlatform:develop Mar 29, 2022
@tpdownes tpdownes deleted the add-troubleshooting-failure-to-destroy-vpc branch March 29, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants