Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include #1831 on develop branch #1834

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Include #1831 on develop branch #1834

merged 2 commits into from
Oct 12, 2023

Conversation

nick-stroud
Copy link
Collaborator

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

samskillman and others added 2 commits October 11, 2023 11:29
@samskillman @tpdownes
Fix install script in ml-slurm example
086b92a 
apt-get update was causing an error during the packer image creation step. An upstream package, specifically `gcsfuse-bullseye`, changed it's Origin and Label. This allows for those values to be updated.
@tpdownes
Merge pull request #1831 from samskillman/fix/ml-slurm_apt-update
9281023 
Fix install script in ml-slurm example
@nick-stroud nick-stroud added the release-chore To not include into release notes label Oct 12, 2023
tpdownes
tpdownes approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Oct 12, 2023
@nick-stroud nick-stroud merged commit 2aa4eaa into develop Oct 12, 2023
10 of 35 checks passed
@tpdownes tpdownes mentioned this pull request Oct 12, 2023
Closed
@nick-stroud nick-stroud deleted the release-candidate branch October 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@nick-stroud nick-stroud

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nick-stroud @tpdownes @samskillman