Front End Deployment Changes #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
cboneti
added
the
release-improvements
cboneti
approved these changes
Oct 27, 2023
|
/gcbrun |
|
WARNING: DO NOT MERGE WITHOUT TALKING TO NAG |
|
@cboneti tested this in my dev environment, everything worked as expected. Can you merge this if it's still possible without rebasing and if the OFE test still fails I will look into that in the separate PR. |
|
/gcbrun |
harshthakkar01
pushed a commit
to harshthakkar01/hpc-toolkit
that referenced
this pull request
Dec 8, 2023
…ployment-changes Front End Deployment Changes
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the Front End source code to be deployed on the service machine through a git clone rather than building a tarball. The deploy.sh script will ask for a forked repository owner and branch (or they can be added to a config file) so that development changes can be tested. It would be best to verify in future work if the branch exists once provided, instead of the possibility of failing once the service machine infrastructure has been created