Test for tty before echo in /etc/profile.d scripts #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
nick-stroud
previously approved these changes
Nov 2, 2023
In spack-setup and ramble-setup modules, profile scripts have echo diag output to the terminal. This breaks some ssh and most scp connections. Therefore, a test is added to ensure that tty output is available. 'test -t 1' is shell-agnostic and tests whether stdout is open.
|
Spack tests passed before rebasing. |
nick-stroud
force-pushed
the
fix-spack-ramble-setups
branch
from
3190a00
to
11769a2
Compare
|
/gcbrun |
nick-stroud
approved these changes
Nov 2, 2023
|
I have been convinced that releasing as is constitutes a regression. I have proposed merging this to release candidate so the fix is in our next release. |
mr0re1
merged commit fd1b5e5
into
GoogleCloudPlatform:release-candidate
6 of 32 checks passed
mr0re1
pushed a commit
to mr0re1/hpc-toolkit
that referenced
this pull request
Nov 2, 2023
…rm#1920) In spack-setup and ramble-setup modules, profile scripts have echo diag output to the terminal. This breaks some ssh and most scp connections. Therefore, a test is added to ensure that tty output is available. 'test -t 1' is shell-agnostic and tests whether stdout is open.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spack-setup and ramble-setup modules, profile scripts have echo diag output to the terminal. This breaks some ssh and most scp connections.
Therefore, a test is added to ensure that tty output is available.
'test -t 1' is shell-agnostic and tests whether stdout is open.