Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix name of HTCondor yum repository Ansible task #1943

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Nov 7, 2023

This is a very simple PR to properly name the task that sets up the HTCondor yum repository. We no longer use the "Feature" (development) branch, but the "LTS" (Long Term Support) branch.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added the release-chore To not include into release notes label Nov 7, 2023
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Nov 7, 2023
@tpdownes
Copy link
Member Author

tpdownes commented Nov 7, 2023

For posterity, the HTCondor build failed for a reason unrelated to the PR: the 2 minute sleep turns out not to be enough to wait for VMs. The fix is to use a built-in feature for waiting for instances in the MIG terraform module. This has a bug associated with it and I may escalate its priority.

@tpdownes tpdownes merged commit 6c5393a into GoogleCloudPlatform:develop Nov 7, 2023
7 of 36 checks passed
@tpdownes tpdownes deleted the htcondor_name_fix branch November 7, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants