Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Zonal with lower capacity band support for filestore instance #1982

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add Zonal with lower capacity band support for filestore instance #1982

merged 1 commit into from
Nov 21, 2023

Conversation

harshthakkar01
Copy link
Contributor

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Nov 21, 2023
@cboneti cboneti assigned harshthakkar01 and unassigned cboneti Nov 21, 2023
@cboneti
Copy link
Member

cboneti commented Nov 21, 2023

Please run the high io test before merging.

@harshthakkar01
Copy link
Contributor Author

/gcbrun

@harshthakkar01 harshthakkar01 merged commit acc12f5 into GoogleCloudPlatform:develop Nov 21, 2023
8 of 36 checks passed
@harshthakkar01 harshthakkar01 deleted the zonal_filestore branch November 21, 2023 21:34
@nick-stroud nick-stroud mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cboneti cboneti cboneti approved these changes

Assignees

@harshthakkar01 harshthakkar01

Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @cboneti