-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slurm6. Add support for dynamic nodeset. #1986
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing this I get the following error:
Error: Resource precondition failed
on .terraform/modules/slurm_controller.slurm_partition/terraform/slurm_cluster/modules/slurm_partition/main.tf line 53, in resource "null_resource" "partition":
53: condition = local.has_node || local.has_dyn || local.has_tpu
├────────────────
│ local.has_dyn is false
│ local.has_node is false
│ local.has_tpu is false
Partition must contain at least one type of nodeset.
Error: Resource precondition failed
on .terraform/modules/slurm_controller.slurm_partition/terraform/slurm_cluster/modules/slurm_partition/main.tf line 57, in resource "null_resource" "partition":
57: condition = ((!local.has_node || !local.has_dyn) && local.has_tpu) || ((local.has_node || local.has_dyn) && !local.has_tpu)
├────────────────
│ local.has_dyn is false
│ local.has_node is false
│ local.has_tpu is false
Partition cannot contain TPU and non-TPU nodesets.
Unlike normal or TPU nodesets, don't add dedicated modules, but instead expect user to specify them DRAFT.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this results in the correct configuration of the dynamic partition.
Unlike normal or TPU nodesets, don't add dedicated modules, but instead expect user to specify them. E.g.: