linter fixes for go and terraform #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding package comments and various other go-lint related fixes. This also updates the python script for omnia install and fixes an outdated branch name for omnia.
Adding package comments and various other go-lint related fixes. This also updates the python script for omnia install and fixes an outdated branch name for omnia.
heyealex
commented
Oct 13, 2021
| @@ -217,48 +218,48 @@ func expandSimpleVariable( | |||
| errorMessages["varNotFound"], context.varString) | |||
| } | |||
| return fmt.Sprintf("((var.%s))", varValue), nil | |||
| } else { // Resource variable | |||
There was a problem hiding this comment.
Here I removed the else {} block since I return from there and don't do anything after. This is more in line with expected go conventions. More info: https://github.com/golang/go/wiki/CodeReviewComments#indent-error-flow
cboneti
approved these changes
Oct 14, 2021
6 tasks
heyealex
added a commit
that referenced
this pull request
Apr 27, 2022
Update paths to community resources throughout the codebase
heyealex
pushed a commit
that referenced
this pull request
Nov 12, 2022
workbench code cleanup and add slurm submit from workbench
6 tasks
mr0re1
added a commit
that referenced
this pull request
Oct 26, 2023
* Augment expression parsing error with position; * Remove `YAML parsing error: ` prefix. ```yaml vars: project_id: $(6 + 4) # Case #1 hello: ((world+)) # Case #2 ``` ```sh YAML parsing error: only traversal expressions are supported, got "6 + 4" YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. Case #1 Error: only traversal expressions are supported, got "6 + 4" 2: project_id: $(6 + 4) Case #2 Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. 2: hello: ((world+)) ```
max-nag
pushed a commit
to max-nag/hpc-toolkit
that referenced
this pull request
Oct 27, 2023
) * Augment expression parsing error with position; * Remove `YAML parsing error: ` prefix. ```yaml vars: project_id: $(6 + 4) # Case #1 hello: ((world+)) # Case GoogleCloudPlatform#2 ``` ```sh YAML parsing error: only traversal expressions are supported, got "6 + 4" YAML parsing error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. Case #1 Error: only traversal expressions are supported, got "6 + 4" 2: project_id: $(6 + 4) Case GoogleCloudPlatform#2 Error: :0,6-6: Missing expression; Expected the start of an expression, but found the end of the file. 2: hello: ((world+)) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding package comments and various other go-lint related fixes. This
also updates the python script for omnia install and fixes an outdated
branch name for omnia.