Tier1 gvnic in simple instance

[nick-stroud]

Submission Checklist

• Have you installed and run this change against pre-commit? pre-commit install
• Are all tests passing? make tests
• If applicable, have you written additional unit tests to cover this
  change?
• Is unit test coverage still above 80%?
• Have you updated any application documentation such as READMEs and user
  guides?
• Have you followed the guidelines in our Contributing document?

[tpdownes]

Address whitespace for sure.

Big picture Q: I see this is doing a simple job of exposing GVNIC + Tier 1 settings for the user in the network configuration. I like that. I believe there are also requirements on the VM image as well as VM family.

I think it is probably best not to address them (allow it to fail at apply) and am wondering if you implicitly agree.

Is there anything else I have to do to make this work? Modify the VPC? I have tried modifying the omnia example to adopt this, and am getting startup-script errors that look like basic networking problems (DNS, no outbound connection, something like that)

[nick-stroud]

I believe there are also requirements on the VM image as well as VM family. I think it is probably best not to address them (allow it to fail at apply) and am wondering if you implicitly agree.

I agree. I have tested that, if machine type is not compatible with tier 1 networking or the OS is not compatible with gVNIC, then apply fails.

[nick-stroud]

I have tried modifying the omnia example to adopt this, and am getting startup-script errors that look like basic networking problems (DNS, no outbound connection, something like that).

I was not able to reproduce. I ran through cloud build and deployed omnia in my local env using bandwidth_tier: tier_1_enabled on the compute instances and they both succeeded. If you believe this is still an issue, can you help me reproduce?

[tpdownes]

I still can't deploy omnia with Tier 1 enabled. But it is stuck waiting on the startup script to complete and I have no reason to believe it would work with default bandwidth tier. I believe this is ready to go but we should add a targeted integration test with Tier 1.

[nick-stroud]

I still can't deploy omnia with Tier 1 enabled. But it is stuck waiting on the startup script to complete and I have no reason to believe it would work with default bandwidth tier. I believe this is ready to go but we should add a targeted integration test with Tier 1.

Curious what is going wrong with your omnia example. I deployed omnia again this morning with tier 1 on and got no error. From discussion with Carlos, I have opened a task to add integration testing for this functionality to our backlog.