Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix wait for startup update #2045

Merged

Conversation

cdunbar13
Copy link
Contributor

@cdunbar13 cdunbar13 commented Dec 13, 2023

This PR is to fix the wait-for-startup script in the wake of the guest agent being updated. We needed to add a new matching string to account for the new error message, which was introduced about a month ago.

Testing was run by creating a vm-instance with a startup script with various changes:

  1. Script that just runs "exit 0"
  2. Script that runs "exit 1"
  3. Script that slept for longer than the timeout
  4. Script that slept and ended before the timeout

Tested on:
Latest hpc-centos-7 image
Latest rocky-8 image
hpc-centos-7-v20220214 - for old agent
rocky-linux-9-v20221102 - for old agent

This issue was introduced by a commit to guest-agent

…d. This checks for an additional string that is now used for return codes that aren't 0
@cdunbar13 cdunbar13 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Dec 13, 2023
nick-stroud
nick-stroud previously approved these changes Dec 13, 2023
@nick-stroud nick-stroud assigned cdunbar13 and unassigned nick-stroud Dec 13, 2023
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR should not be merged until has been manually tested using older releases of the guest-agent.

@tpdownes
Copy link
Member

tpdownes commented Dec 14, 2023

This PR should not be merged until has been manually tested using older releases of the guest-agent.

The offending commit is present in these releases:

@tpdownes tpdownes self-requested a review December 14, 2023 16:05
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further manual testing on old images was successful. I also believe the lustre PR check uses an image before the change in guest-agent.

@tpdownes tpdownes merged commit a7aaccf into GoogleCloudPlatform:main Dec 14, 2023
9 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants