-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix wait for startup update #2045
Hotfix wait for startup update #2045
Conversation
…d. This checks for an additional string that is now used for return codes that aren't 0
(cherry picked from commit 41ff130)
community/modules/scripts/wait-for-startup/scripts/wait-for-startup-status.sh
Show resolved
Hide resolved
community/modules/scripts/wait-for-startup/scripts/wait-for-startup-status.sh
Show resolved
Hide resolved
community/modules/scripts/wait-for-startup/scripts/wait-for-startup-status.sh
Show resolved
Hide resolved
community/modules/scripts/wait-for-startup/scripts/wait-for-startup-status.sh
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR should not be merged until has been manually tested using older releases of the guest-agent.
The offending commit is present in these releases: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Further manual testing on old images was successful. I also believe the lustre PR check uses an image before the change in guest-agent.
This PR is to fix the wait-for-startup script in the wake of the guest agent being updated. We needed to add a new matching string to account for the new error message, which was introduced about a month ago.
Testing was run by creating a vm-instance with a startup script with various changes:
Tested on:
Latest hpc-centos-7 image
Latest rocky-8 image
hpc-centos-7-v20220214
- for old agentrocky-linux-9-v20221102
- for old agentThis issue was introduced by a commit to guest-agent