Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove pre existing fs example and references #2104

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Remove pre existing fs example and references #2104

merged 1 commit into from
Jan 10, 2024

Conversation

harshthakkar01
Copy link
Contributor

[Slurm V4 deprecation]

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Jan 9, 2024
@harshthakkar01 harshthakkar01 merged commit ac5f94a into GoogleCloudPlatform:develop Jan 10, 2024
7 of 36 checks passed
@harshthakkar01 harshthakkar01 deleted the deprecate-pre-existing-fs branch January 10, 2024 06:02
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
Merged
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@harshthakkar01 harshthakkar01

Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @nick-stroud