Validation added to Slurm v5 login_startup_scripts_timeout #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecause it is broken
cdunbar13
added
the
release-bugfix
tpdownes
approved these changes
Jan 23, 2024
community/modules/scheduler/schedmd-slurm-gcp-v5-controller/variables.tf
Outdated
Show resolved
Hide resolved
cdunbar13
merged commit 799674a
into
GoogleCloudPlatform:develop
12 of 33 checks passed
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The login startup scripts timeout value is not being respected in
setup.py. This is because Slurm v5 adds a suffix to the login node, which causes the timeout look up to default to 300s. This is currently being fixed in slurm-gcp, and once a new image is released, this validation can be removed.This meant to be more of a warning for users who try to use this variable. This value would go to the correct location, it just isn't used correctly.