Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copies python binaries instead of symlink for more isolated venv #2151

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Jan 22, 2024

This prevents changes to the system python from affecting our virtual environment.

Tested:

  • Built image using this pr and ran ansible using the built image.
  • I also observed under some conditions this avoided the venv from being corrupted when system python changed.

Note: This did not resolve the issue I have observed with the selinux python library when building Slurm on Rocky8.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jan 22, 2024
Copy link
Member

@tpdownes tpdownes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like this merits at least one successful integration test despite superficially being harmless.

@tpdownes tpdownes assigned nick-stroud and unassigned tpdownes Jan 22, 2024
@nick-stroud
Copy link
Collaborator Author

I feel like this merits at least one successful integration test despite superficially being harmless.

Running PR-test-hcls, PR-test-lustre-vm, and PR-test-packer to get some coverage.

@nick-stroud nick-stroud merged commit 4753f3b into GoogleCloudPlatform:develop Jan 23, 2024
10 of 36 checks passed
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants