Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add login node in the spack openfoam tutorial example #2170

Merged

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Jan 26, 2024

This PR adds login node in spack-openfoam tutorial example.
Manual Test on login node sbatch /opt/apps/openfoam/submit_openfoam.sh

[ext_harshthakkar_google_com@spackopenf-login-login-001 test_run]$ ls
0         hostfile     processor12  processor17  processor21  processor26  processor30  processor35  processor4   processor44  processor49  processor53  processor58  processor9
0.orig    processor0   processor13  processor18  processor22  processor27  processor31  processor36  processor40  processor45  processor5   processor54  processor59  slurm-1.out
Allclean  processor1   processor14  processor19  processor23  processor28  processor32  processor37  processor41  processor46  processor50  processor55  processor6   system
Allrun    processor10  processor15  processor2   processor24  processor29  processor33  processor38  processor42  processor47  processor51  processor56  processor7
constant  processor11  processor16  processor20  processor25  processor3   processor34  processor39  processor43  processor48  processor52  processor57  processor8
[ext_harshthakkar_google_com@spackopenf-login-login-001 test_run]$

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Jan 26, 2024
@harshthakkar01 harshthakkar01 merged commit caf844f into GoogleCloudPlatform:develop Jan 26, 2024
8 of 35 checks passed
@harshthakkar01 harshthakkar01 deleted the fix-openfoam branch January 26, 2024 19:30
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants