Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: added new variables to ml-slurm integration test #2172

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fix: added new variables to ml-slurm integration test #2172

merged 1 commit into from
Jan 26, 2024

Conversation

nick-stroud
Copy link
Collaborator

Fixes breakage caused by #2155

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@nick-stroud nick-stroud added the release-chore To not include into release notes label Jan 26, 2024
@tpdownes tpdownes merged commit 65f4126 into GoogleCloudPlatform:develop Jan 26, 2024
8 of 34 checks passed
@nick-stroud nick-stroud assigned nick-stroud and unassigned tpdownes Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@nick-stroud nick-stroud

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-stroud @tpdownes