Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Slurm-GCP release to 5.10.2 #2189

Merged
merged 1 commit into from
Feb 5, 2024
Merged

Update Slurm-GCP release to 5.10.2 #2189

merged 1 commit into from
Feb 5, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Feb 1, 2024

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added the do-not-merge Block merging of this PR label Feb 1, 2024
@tpdownes tpdownes self-assigned this Feb 1, 2024
@tpdownes tpdownes force-pushed the slurm_5_10_2 branch 5 times, most recently from 6b3be42 to 4328f89 Compare February 2, 2024 21:30
@tpdownes
Copy link
Member Author

tpdownes commented Feb 2, 2024

For record: PR-test-hpc-enterprise-slurm failed due to a stockout of N2 VMs in the region.

@tpdownes tpdownes added release-version-updates Added to release notes under the "Version Updates" heading. and removed do-not-merge Block merging of this PR labels Feb 5, 2024
@tpdownes tpdownes marked this pull request as ready for review February 5, 2024 19:32
@tpdownes tpdownes assigned cdunbar13 and unassigned tpdownes Feb 5, 2024
cdunbar13
cdunbar13 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@cdunbar13 cdunbar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpdownes
Copy link
Member Author

tpdownes commented Feb 5, 2024

The lustre test failed twice due to stockout.

@tpdownes tpdownes merged commit 4e85201 into develop Feb 5, 2024
18 of 39 checks passed
@tpdownes tpdownes deleted the slurm_5_10_2 branch February 6, 2024 14:37
@tpdownes tpdownes mentioned this pull request Feb 9, 2024
Merged
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
Merged
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdunbar13 cdunbar13 cdunbar13 approved these changes

Assignees

@cdunbar13 cdunbar13

Labels
release-version-updates Added to release notes under the "Version Updates" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @cdunbar13