Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Dell Omnia module and example blueprint #2196

Merged
merged 1 commit into from
Feb 3, 2024
Merged

Deprecate Dell Omnia module and example blueprint #2196

merged 1 commit into from
Feb 3, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Feb 2, 2024

The integration test removed by this PR has been removed already.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

nick-stroud
nick-stroud approved these changes Feb 2, 2024
View reviewed changes
examples/README.md Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@nick-stroud nick-stroud assigned tpdownes and unassigned nick-stroud Feb 2, 2024
@tpdownes tpdownes added the release-deprecations Added to release notes under the "Deprecations" heading. label Feb 2, 2024
@tpdownes tpdownes merged commit bb029ed into GoogleCloudPlatform:develop Feb 3, 2024
7 of 33 checks passed
@tpdownes tpdownes deleted the deprecate_omnia branch February 5, 2024 20:03
@mr0re1 mr0re1 mentioned this pull request Feb 12, 2024
Merged
@nick-stroud nick-stroud mentioned this pull request Feb 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@tpdownes tpdownes

Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @nick-stroud