Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrite logic for create #221

Merged

Conversation

nick-stroud
Copy link
Collaborator

@nick-stroud nick-stroud commented Apr 19, 2022

Adds logic that decides whether or not a blueprint should be overwritten on create. It takes into account if the user has approved the action and makes sure that no resource groups are being deleted, which would have the effect of erasing state.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@nick-stroud nick-stroud self-assigned this Apr 19, 2022
@nick-stroud nick-stroud force-pushed the overwrite_logic branch 2 times, most recently from 225ed71 to 80a63c8 Compare April 20, 2022 21:26
@nick-stroud nick-stroud assigned heyealex and unassigned nick-stroud Apr 20, 2022
@nick-stroud nick-stroud marked this pull request as ready for review April 20, 2022 21:26
pkg/reswriter/reswriter.go Outdated Show resolved Hide resolved
@heyealex heyealex assigned nick-stroud and unassigned heyealex Apr 20, 2022
@nick-stroud nick-stroud merged commit 70a8e77 into GoogleCloudPlatform:develop Apr 20, 2022
@nick-stroud nick-stroud deleted the overwrite_logic branch April 28, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants