Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Packer template #224

Merged
merged 3 commits into from
Apr 20, 2022
Merged

Improve Packer template #224

merged 3 commits into from
Apr 20, 2022

Conversation

tpdownes
Copy link
Member

  • Add support for Shared VPC networks
  • Use modern required plugin syntax (similar to Terraform provider version constraints)
  • Convert to hashtag comment syntax (following recommendation by tflint)

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

@cboneti cboneti assigned tpdownes and unassigned cboneti Apr 20, 2022
@tpdownes tpdownes assigned cboneti and unassigned tpdownes Apr 20, 2022
cboneti
cboneti previously approved these changes Apr 20, 2022
Copy link
Member

@cboneti cboneti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if the integration tests pass.

@tpdownes
Copy link
Member Author

Integration test is indicating we need an explicit packer init (which was implied before). I will add that to integration test as well as to the instructions printed to screen when using a packer resource.

- Add packer init to integration test
- Add packer init to README
- Add packer init to ghpc instructions
@tpdownes tpdownes merged commit 9a65f76 into GoogleCloudPlatform:develop Apr 20, 2022
@tpdownes tpdownes deleted the feat_packer_sharedvpc_plugin branch April 21, 2022 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants