Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial commit of firewall-rules module #2244

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Initial commit of firewall-rules module #2244

merged 2 commits into from
Feb 15, 2024

Conversation

tpdownes
Copy link
Member

The firewall-rules module can be used internally by the Toolkit to create application-specific firewall rules or in blueprints in conjuction with the pre-existing-vpc module to ensure that traffic required by the blueprint is allowed.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes requested a review from mr0re1 February 15, 2024 16:56
@tpdownes tpdownes added the release-new-modules Added to release notes under the "New Modules" heading. label Feb 15, 2024
@tpdownes
Initial commit of firewall-rules module
b6cae6b 
The firewall-rules module can be used internally by the Toolkit to
create application-specific firewall rules or in blueprints in
conjuction with the pre-existing-vpc module to ensure that traffic
required by the blueprint is allowed.
@tpdownes
Adopt firewall-rules module in ml-slurm example
a3045c7
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Feb 15, 2024
@tpdownes tpdownes merged commit f7c5cd7 into GoogleCloudPlatform:develop Feb 15, 2024
9 of 33 checks passed
@tpdownes tpdownes deleted the firewall_rules_module branch February 15, 2024 21:59
@tpdownes tpdownes restored the firewall_rules_module branch February 15, 2024 23:17
@tpdownes tpdownes deleted the firewall_rules_module branch February 15, 2024 23:21
@alyssa-sm alyssa-sm mentioned this pull request Mar 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@tpdownes tpdownes

Labels
release-new-modules Added to release notes under the "New Modules" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @mr0re1