Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split service account creation from htcondor-setup #2250

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

tpdownes
Copy link
Member

Some users do not have IAM permissions to create service accounts with project-wide roles/permissions. This commit splits service account creation of the htcondor-setup module into an independent module. It also refactors each affected module to use internal Toolkit modules.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes added the do-not-merge Block merging of this PR label Feb 16, 2024
@tpdownes tpdownes self-assigned this Feb 16, 2024
@tpdownes tpdownes added release-new-modules Added to release notes under the "New Modules" heading. and removed do-not-merge Block merging of this PR labels Feb 16, 2024
@tpdownes tpdownes marked this pull request as ready for review February 16, 2024 21:14
@tpdownes tpdownes removed their assignment Feb 16, 2024
@tpdownes tpdownes requested a review from mr0re1 February 16, 2024 21:14
@tpdownes tpdownes changed the title [WIP] Split service account creation from htcondor-setup Split service account creation from htcondor-setup Feb 16, 2024
@mr0re1 mr0re1 assigned tpdownes and unassigned mr0re1 Feb 20, 2024
Some users do not have IAM permissions to create service accounts with
project-wide roles/permissions. This commit splits service account
creation of the htcondor-setup module into an independent module. It
also refactors each affected module to use internal Toolkit modules.
@tpdownes tpdownes merged commit 51e3580 into GoogleCloudPlatform:develop Feb 21, 2024
8 of 33 checks passed
@tpdownes tpdownes deleted the split_htcondor_setup branch February 21, 2024 15:32
@alyssa-sm alyssa-sm mentioned this pull request Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-new-modules Added to release notes under the "New Modules" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants