Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slurm v6 version for image builder blueprint #2297

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Feb 28, 2024

This PR adds blueprint, test files to use Slurm v6 modules for image builder blueprint. This also adds description in example/README file.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Feb 28, 2024
examples/README.md Outdated Show resolved Hide resolved
@nick-stroud nick-stroud added the do-not-merge Block merging of this PR label Feb 28, 2024
@harshthakkar01 harshthakkar01 changed the title Update image builder blueprint to use v6 and mark v5 version as legacy Add Slurm v6 version for image builder blueprint Feb 29, 2024
@harshthakkar01 harshthakkar01 removed the do-not-merge Block merging of this PR label Feb 29, 2024
examples/image-builder-v6.yaml Outdated Show resolved Hide resolved
examples/image-builder-v6.yaml Outdated Show resolved Hide resolved
examples/image-builder-v6.yaml Outdated Show resolved Hide resolved
tools/cloud-build/daily-tests/builds/packer-v6.yaml Outdated Show resolved Hide resolved
tools/cloud-build/daily-tests/tests/packer-v6.yml Outdated Show resolved Hide resolved
tools/cloud-build/daily-tests/tests/packer-v6.yml Outdated Show resolved Hide resolved
@harshthakkar01 harshthakkar01 force-pushed the v6-update-image-builder branch 3 times, most recently from 1447c14 to 4d20303 Compare March 4, 2024 21:51
examples/README.md Show resolved Hide resolved
tools/cloud-build/daily-tests/builds/packer-v6.yaml Outdated Show resolved Hide resolved
@harshthakkar01 harshthakkar01 merged commit dd4b20f into GoogleCloudPlatform:develop Mar 4, 2024
10 of 38 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants