Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove slurm-gcp high io blueprint and integration test #2330

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Remove slurm-gcp high io blueprint and integration test #2330

merged 1 commit into from
Mar 15, 2024

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Mar 7, 2024 •
edited
Loading

This PR adds SlurmGCP v6 version of high-io blueprint and adds integration test for it.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 added the release-improvements Added to release notes under the "Improvements" heading. label Mar 7, 2024
@harshthakkar01 harshthakkar01 marked this pull request as ready for review March 7, 2024 20:41
@harshthakkar01 harshthakkar01 changed the title Add slurm-gcp-high-io-v6 blueprint example and integration test Remove slurm-gcp high io blueprint and integration test Mar 12, 2024
@harshthakkar01 harshthakkar01 added release-chore To not include into release notes and removed release-improvements Added to release notes under the "Improvements" heading. labels Mar 12, 2024
@harshthakkar01 harshthakkar01 merged commit 4c0be24 into GoogleCloudPlatform:develop Mar 15, 2024
13 of 45 checks passed
@harshthakkar01 harshthakkar01 deleted the v6-slurm-gcp-high-io branch March 15, 2024 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nick-stroud nick-stroud nick-stroud approved these changes

Assignees

@harshthakkar01 harshthakkar01

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @nick-stroud