Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename internal schema data structures and variable names #258

Conversation

heyealex
Copy link
Contributor

BlueprintConfig -> DeploymentConfig
YamlConfig -> Blueprint
ResourceGroup -> DeploymentGroup
Resource -> Module

Along with multiple other support data structures and variables. There are (very) likely leftover references that will need to be cleaned up as we find them, but this was a best-effort to grep/replace as much as possible.

Anything related to package names were not updated, including a few functions like WriteBlueprint. That will come in a future PR.

Submission Checklist

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

@heyealex heyealex requested a review from tpdownes May 2, 2022 18:18
@tpdownes tpdownes self-assigned this May 2, 2022
@heyealex heyealex force-pushed the refactor/rename-insternal-schema branch from 38f2b9e to 8ece1de Compare May 2, 2022 19:38
@heyealex heyealex mentioned this pull request May 3, 2022
6 tasks
cboneti
cboneti previously approved these changes May 3, 2022
@cboneti cboneti removed the request for review from tpdownes May 3, 2022 23:20
@cboneti cboneti assigned heyealex and unassigned tpdownes and cboneti May 3, 2022
@heyealex heyealex merged commit 47505fa into GoogleCloudPlatform:develop May 4, 2022
@heyealex heyealex deleted the refactor/rename-insternal-schema branch May 4, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants