Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 'pre-existing-gke-cluster' module #2704

Merged
merged 4 commits into from
Jun 26, 2024

Conversation

sharabiani
Copy link
Collaborator

@sharabiani sharabiani commented Jun 20, 2024

This PR introduces the pre-existing-gke-cluster module, allowing blueprints to leverage existing Google Kubernetes Engine (GKE) clusters.

Key Changes:

New Module:

Purpose: Facilitates the usage of a pre-existing GKE cluster in HPC Toolkit blueprints.
Location: community/modules/scheduler/pre-existing-gke-cluster
Inputs:

  • cluster_name (required): Name of the existing GKE cluster.
  • project_id (required): Project that hosts the existing cluster.
  • region (required): Region in which to search for the cluster

Manual testing:

  1. Created a new GKE cluster.
  2. Deployed the provided sample blueprint (hpc-existing-gke).
  3. Verified the successful creation of a new node pool in the GKE cluster through Pantheon.

Sample Blueprint:

blueprint_name: hpc-existing-gke

vars:

 project_id: ## Set GCP Project ID Here ##

 deployment_name: existing-cluster-01

 region: us-central1



deployment_groups:

- group: primary

 modules:

 - id: existing_cluster

  source: community/modules/scheduler/pre-existing-gke-cluster

  settings:

   cluster_name: "cluster-01"



 - id: compute_pool

  source: community/modules/compute/gke-node-pool

  use: [existing_cluster]



 - id: job-template

  source: community/modules/compute/gke-job-template

  use: [compute_pool]

  settings:

   image: busybox

   command:

   - echo

   - Hello World

   node_count: 3

  outputs: [instructions]

Additional Notes:

  • Made changes to relevant documentation.

@nick-stroud nick-stroud self-requested a review June 20, 2024 16:24
@nick-stroud nick-stroud self-assigned this Jun 20, 2024
@nick-stroud nick-stroud added the release-new-modules Added to release notes under the "New Modules" heading. label Jun 20, 2024
@nick-stroud
Copy link
Collaborator

You can ignore PR-test-ml-gke failure, this is a new integration test that is just not defined in your pr.

auto-merge was automatically disabled June 25, 2024 23:21

Pull request was closed

@nick-stroud nick-stroud reopened this Jun 25, 2024
@nick-stroud
Copy link
Collaborator

/gcbrun

@nick-stroud nick-stroud added release-new-modules Added to release notes under the "New Modules" heading. and removed release-new-modules Added to release notes under the "New Modules" heading. labels Jun 25, 2024
@sharabiani sharabiani added the release-new-modules Added to release notes under the "New Modules" heading. label Jun 25, 2024
@nick-stroud nick-stroud merged commit c5366ee into GoogleCloudPlatform:develop Jun 26, 2024
9 of 54 checks passed
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-new-modules Added to release notes under the "New Modules" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants