-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create 'pre-existing-gke-cluster' module #2704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick-stroud
added
the
release-new-modules
Added to release notes under the "New Modules" heading.
label
Jun 20, 2024
nick-stroud
requested changes
Jun 25, 2024
community/modules/scheduler/pre-existing-gke-cluster/versions.tf
Outdated
Show resolved
Hide resolved
nick-stroud
approved these changes
Jun 25, 2024
You can ignore PR-test-ml-gke failure, this is a new integration test that is just not defined in your pr. |
/gcbrun |
nick-stroud
added
release-new-modules
Added to release notes under the "New Modules" heading.
and removed
release-new-modules
Added to release notes under the "New Modules" heading.
labels
Jun 25, 2024
sharabiani
added
the
release-new-modules
Added to release notes under the "New Modules" heading.
label
Jun 25, 2024
nick-stroud
merged commit Jun 26, 2024
c5366ee
into
GoogleCloudPlatform:develop
9 of 54 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the pre-existing-gke-cluster module, allowing blueprints to leverage existing Google Kubernetes Engine (GKE) clusters.
Key Changes:
New Module:
Purpose: Facilitates the usage of a pre-existing GKE cluster in HPC Toolkit blueprints.
Location: community/modules/scheduler/pre-existing-gke-cluster
Inputs:
Manual testing:
Sample Blueprint:
Additional Notes: