Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add disk_type for HTCondor's EP template #2705

Merged
merged 3 commits into from
Jul 1, 2024
Merged

Add disk_type for HTCondor's EP template #2705

merged 3 commits into from
Jul 1, 2024

Conversation

aneo-ssam
Copy link
Contributor

Submission Checklist

Please take the following actions before submitting this pull request.

  • ✅Fork your PR branch from the Toolkit "develop" branch (not main)
  • ✅Test all changes with pre-commit in a local branch #
  • ✅Confirm that "make tests" passes all tests
  • ✅Add or modify unit tests to cover code changes
  • ✅Ensure that unit test coverage remains above 80%
  • ✅Update all applicable documentation
  • ✅Follow Cloud HPC Toolkit Contribution guidelines #

@aneo-ssam aneo-ssam changed the title Develop Add disk_type for HTCondor's EP template Jun 20, 2024
@tpdownes tpdownes self-requested a review June 25, 2024 19:05
@tpdownes tpdownes self-assigned this Jun 25, 2024
@tpdownes
Copy link
Member

/gcbrun

@tpdownes tpdownes self-requested a review July 1, 2024 13:36
@tpdownes
Copy link
Member

tpdownes commented Jul 1, 2024

/gcbrun

@tpdownes tpdownes added the release-module-improvements Added to release notes under the "Module Improvements" heading. label Jul 1, 2024
@tpdownes tpdownes merged commit eed8fe8 into GoogleCloudPlatform:develop Jul 1, 2024
10 of 52 checks passed
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpdownes tpdownes tpdownes approved these changes

Assignees

@tpdownes tpdownes

@aneo-ssam aneo-ssam

Labels
release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aneo-ssam @tpdownes