Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gke optional accelerator #2736

Merged

Conversation

ankitkinra
Copy link
Contributor

@ankitkinra ankitkinra commented Jul 2, 2024

Make GKE guest_accelerator_config truly optional

With this fix following nodepool configuration will be supported, where type/count are picked up from g2-standard-4 but the driver is picked from configuration

- id: g2_pool
    source: community/modules/compute/gke-node-pool
    use: [gke_cluster]
    settings:
      name: g2-latest-driver
      disk_type: pd-balanced
      machine_type: g2-standard-4
      guest_accelerator:
      - gpu_driver_installation_config:
        - gpu_driver_version: "LATEST"

In the below configuration for n1_pool where the gpu_driver_version is defaulted to DEFAULT

  - id: n1_pool_defaults
    source: community/modules/compute/gke-node-pool
    use: [gke_cluster]
    settings:
      name: n1-pool-defaults
      disk_type: pd-balanced
      machine_type: n1-standard-1
      guest_accelerator:
      - type: nvidia-tesla-t4
        count: 2

@ankitkinra ankitkinra changed the base branch from main to develop July 2, 2024 20:16
@ankitkinra ankitkinra added the release-improvements Added to release notes under the "Improvements" heading. label Jul 11, 2024
@ankitkinra ankitkinra marked this pull request as ready for review July 11, 2024 17:02
community/modules/compute/gke-node-pool/README.md Outdated Show resolved Hide resolved
community/modules/compute/gke-node-pool/variables.tf Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
community/modules/compute/gke-node-pool/main.tf Outdated Show resolved Hide resolved
examples/README.md Outdated Show resolved Hide resolved
@nick-stroud nick-stroud removed their assignment Jul 12, 2024
…celerator

* Updated node_pool README to reflect the guest_accelerator changes for gpu families
@ankitkinra ankitkinra merged commit a1923fc into GoogleCloudPlatform:develop Jul 15, 2024
9 of 49 checks passed
@ankitkinra ankitkinra deleted the gke-optional-accelerator branch July 15, 2024 17:17
@nick-stroud nick-stroud mentioned this pull request Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-improvements Added to release notes under the "Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants