Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Develop and adopt boot-time fix for EOL CentOS 7 repositories #2738

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Jul 2, 2024

This PR introduces a new runner intended to apply early-boot hotfixes on VMs that use our startup-script module. It is chained as 3 commits:

  1. The early boot hotfix itself
  2. Adoption of the hotfix in the vm-instance module's use of startup-script
  3. Un an integration test that will make use of 1+2, swap the centos-7 VM family name for image ID because all images in the family are now deprecated (i.e. you can't use the family name to get latest non-deprecated image)

Observed in logs:

Jul  2 22:31:09 testfix-0 startup-script-stdlib[1236]: === start executing runner: early_run_hotfixes.sh-b383 ===
Jul  2 22:31:09 testfix-0 google_metadata_script_runner: startup-script: Tue Jul 02 22:31:09 +0000 2024 Info [1236]: === start executing runner: early
_run_hotfixes.sh-b383 ===
Jul  2 22:31:09 testfix-0 google_metadata_script_runner: startup-script: Applying hotfixes for CentOS 7
Jul  2 22:31:09 testfix-0 google_metadata_script_runner: startup-script: Removing mirrorlist from default CentOS 7 repositories
Jul  2 22:31:09 testfix-0 google_metadata_script_runner: startup-script: Reconfiguring default CentOS 7 repositories to use CentOS Vault
Jul  2 22:31:09 testfix-0 startup-script-stdlib[1236]: === early_run_hotfixes.sh-b383 finished with exit_code=0 ===

On a repeated run, you (correctly) only observe the first message:

Jul  2 22:32:51 testfix-0 startup-script-stdlib[1811]: === start executing runner: early_run_hotfixes.sh-b383 ===
Jul  2 22:32:51 testfix-0 google_metadata_script_runner: startup-script: Tue Jul 02 22:32:51 +0000 2024 Info [1811]: === start executing runner: early_run_hotfixes.sh-b383 ===
Jul  2 22:32:51 testfix-0 google_metadata_script_runner: startup-script: Applying hotfixes for CentOS 7

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

This hotfix applies changes to the yum repository configuration that are
necessary after the EOL of CentOS 7.
The centos-7 family has been entirely deprecated. This change uses the
final image from the family in integration tests until we elect to
remove CentOS 7 testing entirely from the Toolkit.
@tpdownes tpdownes self-assigned this Jul 2, 2024
@tpdownes tpdownes requested a review from rohitramu July 2, 2024 22:26
@tpdownes tpdownes assigned rohitramu and unassigned tpdownes Jul 2, 2024
@tpdownes tpdownes marked this pull request as ready for review July 2, 2024 22:27
@tpdownes tpdownes added the release-key-new-features Added to release notes under the "Key New Features" heading. label Jul 2, 2024
@tpdownes tpdownes enabled auto-merge July 2, 2024 22:34
@rohitramu rohitramu assigned tpdownes and unassigned rohitramu Jul 2, 2024
@tpdownes tpdownes merged commit d884da5 into develop Jul 2, 2024
19 of 62 checks passed
@tpdownes tpdownes deleted the vm_lustre_fix branch July 2, 2024 23:41
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-key-new-features Added to release notes under the "Key New Features" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants