Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify a3-highgpu-8g image-building blueprint network #2744

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Modify a3-highgpu-8g image-building blueprint network #2744

merged 1 commit into from
Jul 10, 2024

Conversation

tpdownes
Copy link
Member

@tpdownes tpdownes commented Jul 8, 2024 •
edited
Loading

Match updated values from 5cb9faa. Note: I accidentally named the branch with "a3mega" but this intentionally targets the a3-highgpu-8g blueprint.

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cloud HPC Toolkit Contribution guidelines #

@tpdownes tpdownes self-assigned this Jul 8, 2024
@tpdownes tpdownes added the release-bugfix Added to release notes under the "Bug fixes" heading. label Jul 8, 2024
@tpdownes tpdownes marked this pull request as ready for review July 8, 2024 19:45
@tpdownes tpdownes requested a review from cdunbar13 July 8, 2024 19:45
@tpdownes tpdownes assigned cdunbar13 and unassigned tpdownes Jul 8, 2024
@tpdownes tpdownes merged commit c8bc08c into GoogleCloudPlatform:develop Jul 10, 2024
13 of 54 checks passed
@tpdownes tpdownes deleted the fix_a3mega_image branch July 10, 2024 15:27
@ankitkinra ankitkinra mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdunbar13 cdunbar13 cdunbar13 approved these changes

Assignees

@cdunbar13 cdunbar13

Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpdownes @cdunbar13