Enable VPC module to accept subnetwork_name input variable #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboneti
reviewed
May 10, 2022
|
I have made modification based on out-of-band conversation to re-work |
|
Build tests failed due to hitting an internal Filestore quota. Re-running them. GitHub should update once they complete. |
cboneti
reviewed
May 10, 2022
modules/network/vpc/variables.tf
Outdated
| Primary (default) subnetwork in which to create resources. If null, a default value will be constructed. | ||
|
|
||
| subnet_name (string, required, Name of subnet; will be replaced by var.subnetwork_name or its default value) | ||
| subnet_region (string, requiered, will be replaced by var.region) |
modules/network/vpc/variables.tf
Outdated
| purpose (string, optional, related to Load Balancing) | ||
| role (string, optional, related to Load Balancing) | ||
| subnet_name (string, required, Name of subnet; will be replaced by var.subnetwork_name or its default value) | ||
| subnet_region (string, requiered, will be replaced by var.region) |
* Re-work primary_subnetwork as an input variable that defaults to null. If no value is supplied, then a default is constructed in a local variable. If a value is supplied, then it is taken explicitly. * Construct local block from new input variables subnetwork_name and subnetwork_size. The former aligns with Toolkit naming conventions and simplifies multi-group blueprints when network_name and subnetwork_name are set as global variables. In particular, this allows the pre-existing-vpc module in group N to detect a VPC created by the vpc module in group M, where M < N.
* Adopt new feature in VPC module to allow explicit specification of both network_name and subnetwork_name; current image building example works because Packer template defaults to same subnetwork_name as VPC module
* The Packer template was previously designed to default to the same subnetwork_name as is created by the VPC module. This behavior was intentional to allow for more automatic harmony when a user creates a VPC without specifying a value. * This change intentionally requires the user to specify subnetwork_name. It is anticipated that the most common use case will be to specify subnetwork_name globally.
* Current solution relies on alignment of globally-set subnetwork_name with value created by VPC module. Updates to the VPC module no longer require this, so adopt a value that is more arbitrary.
cboneti
approved these changes
May 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose subnetwork_name as a top-level variable to the VPC module to allow multi-group blueprints to succeed when network_name and subnetwork_name are set as global variables. In particular, this allows the pre-existing-vpc module in group N to detect a VPC created by the vpc module in group M, where M < N.If no value is supplied, then a default is constructed in a local
variable. If a value is supplied, then it is taken explicitly.
subnetwork_size. The former aligns with Toolkit naming conventions and
simplifies multi-group blueprints when network_name and subnetwork_name
are set as global variables. In particular, this allows the
pre-existing-vpc module in group N to detect a VPC created by the vpc
module in group M, where M < N.
Submission Checklist
pre-commit installmake testschange?
guides?