Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement kubectl-apply module #2980

Merged

Conversation

sharabiani
Copy link
Collaborator

Kubectl-apply module implemented:

It supports:

  • String manifest body
  • Local files
  • Local template files
  • URLs
  • Directories containing yaml and template files

gke-cluster updated and pre-existing-gke-cluster updated:

  • To replace kubectl provider with kubectl-apply module to apply create newtrok objects for multinetworking
  • To template files as manifests instead of raw content

The template files in gke-cluster and pre-existing-gke-cluster are added to duplicate diff

Submission Checklist

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@sharabiani sharabiani added release-new-modules Added to release notes under the "New Modules" heading. release-module-improvements Added to release notes under the "Module Improvements" heading. labels Aug 28, 2024
@sharabiani sharabiani self-assigned this Aug 28, 2024
modules/management/kubectl-apply/README.md Outdated Show resolved Hide resolved
modules/management/kubectl-apply/README.md Outdated Show resolved Hide resolved
modules/management/kubectl-apply/kubectl/variables.tf Outdated Show resolved Hide resolved
modules/management/kubectl-apply/kubectl/variables.tf Outdated Show resolved Hide resolved
modules/management/kubectl-apply/kubectl/outputs.tf Outdated Show resolved Hide resolved
modules/management/kubectl-apply/variables.tf Show resolved Hide resolved
modules/management/kubectl-apply/outputs.tf Outdated Show resolved Hide resolved
modules/management/kubectl-apply/providers.tf Outdated Show resolved Hide resolved
@sharabiani sharabiani merged commit d74c2e0 into GoogleCloudPlatform:develop Sep 5, 2024
8 of 52 checks passed
@tpdownes tpdownes mentioned this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-module-improvements Added to release notes under the "Module Improvements" heading. release-new-modules Added to release notes under the "New Modules" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants