Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update network_ip to use empty string #3076

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Conversation

tpdownes
Copy link
Member

Enables compatibility with

https://github.com/GoogleCloudPlatform/slurm-gcp/blob/5b883492c8b99d8da5e7cc39c06a9d15b5700c85/terraform/slurm_cluster/modules/_instance_template/main.tf#L147

I will submit a PR to that repo to make the code treat null and empty string identically.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@cdunbar13 cdunbar13 assigned tpdownes and unassigned cdunbar13 Sep 26, 2024
@tpdownes tpdownes added the release-chore To not include into release notes label Sep 26, 2024
@tpdownes tpdownes merged commit 3361e82 into experimental Sep 26, 2024
9 of 55 checks passed
@tpdownes tpdownes deleted the fix_network_ip branch September 26, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants