-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental Networking Features for GKE #3114
Experimental Networking Features for GKE #3114
Conversation
RDMA Support in GKE Blueprints
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now. There is at least one issue that should be addressed in another PR.
Fixing subnetwork_name = "${var.rdma_subnetwork_name_prefix}-${idx}",
in the gke-cluster and pre-existing-gke-cluster. This should use the subnetwork name that comes from the networks that are passed in (either require subnetworks to be populated in the list or get the information from a data source)
658bbb1
into
GoogleCloudPlatform:experimental
Move the experimental GKE networking features to the experimental branch.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.