Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental Networking Features for GKE #3114

Merged

Conversation

arajmane-g
Copy link
Contributor

Move the experimental GKE networking features to the experimental branch.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

modules/compute/gke-node-pool/main.tf Outdated Show resolved Hide resolved
modules/compute/gke-node-pool/variables.tf Outdated Show resolved Hide resolved
modules/compute/gke-node-pool/variables.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
modules/scheduler/gke-cluster/main.tf Outdated Show resolved Hide resolved
modules/scheduler/pre-existing-gke-cluster/main.tf Outdated Show resolved Hide resolved
Copy link
Contributor

@cdunbar13 cdunbar13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. There is at least one issue that should be addressed in another PR.

Fixing subnetwork_name = "${var.rdma_subnetwork_name_prefix}-${idx}", in the gke-cluster and pre-existing-gke-cluster. This should use the subnetwork name that comes from the networks that are passed in (either require subnetworks to be populated in the list or get the information from a data source)

@cdunbar13 cdunbar13 merged commit 658bbb1 into GoogleCloudPlatform:experimental Oct 11, 2024
5 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants