Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update badge for slurm-gcp v5 and slurm-gcp v6 #3116

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Update badge for slurm-gcp v5 and slurm-gcp v6 #3116

merged 1 commit into from
Oct 15, 2024

Conversation

harshthakkar01
Copy link
Contributor

@harshthakkar01 harshthakkar01 commented Oct 9, 2024 •
edited
Loading

This PR,

  • Marks Slurm-gcp v5 blueprints and modules as deprecated
  • Updates slurm-gcp v6 modules to core

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@harshthakkar01 harshthakkar01 self-assigned this Oct 9, 2024
@harshthakkar01 harshthakkar01 added the release-deprecations Added to release notes under the "Deprecations" heading. label Oct 9, 2024
@harshthakkar01 harshthakkar01 force-pushed the make-v5-deprecated branch 3 times, most recently from 4420592 to d6475df Compare October 11, 2024 23:39
@harshthakkar01 harshthakkar01 changed the title Mark slurm-gcp v5 version of blueprints as deprecated Update badge for slurm-gcp v5 and slurm-gcp v6 Oct 14, 2024
@mr0re1 mr0re1 assigned harshthakkar01 and unassigned mr0re1 Oct 15, 2024
@harshthakkar01 harshthakkar01 merged commit 520207f into GoogleCloudPlatform:develop Oct 15, 2024
10 of 56 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request Oct 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@harshthakkar01 harshthakkar01

Labels
release-deprecations Added to release notes under the "Deprecations" heading.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@harshthakkar01 @mr0re1