gke-node-pool default name conflict fixed #3127
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the default name conflicts when multiple gke-node-pool is added to a blueprint with a same machine type and without specifying a name.
The machine_type used to be considered as name for the node-pool so in the above scenario multiple modules were trying to create the same node-pool. Now the default name will be machine_type + module id which is unique blueprint-wide.
Sample node-pool name:
c2-standard-60-computepool-03
Manual tests:
1- A blueprint including multiple gke-node-pool with the same name created:
2- Blueprint deployed succesfully and verified by GCP Console nodepools creation with names like the sample name above
3- A new node-pool added to the blueprint:
4- Blueprint deployed succesfully and verified by GCP Console only the new nodepool created with name like the sample name above
5- Destroyed the the cluster successfully