Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gke-node-pool default name conflict fixed #3127

Merged

Conversation

sharabiani
Copy link
Collaborator

@sharabiani sharabiani commented Oct 11, 2024

This PR fixes the default name conflicts when multiple gke-node-pool is added to a blueprint with a same machine type and without specifying a name.

The machine_type used to be considered as name for the node-pool so in the above scenario multiple modules were trying to create the same node-pool. Now the default name will be machine_type + module id which is unique blueprint-wide.

Sample node-pool name: c2-standard-60-computepool-03

Manual tests:

1- A blueprint including multiple gke-node-pool with the same name created:

  - id: compute_pool
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

  - id: compute_pool_01
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

  - id: compute_pool_02
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

2- Blueprint deployed succesfully and verified by GCP Console nodepools creation with names like the sample name above

3- A new node-pool added to the blueprint:

  - id: compute_pool
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

  - id: compute_pool_01
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

  - id: compute_pool_02
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

  - id: compute_pool_03
    source: modules/compute/gke-node-pool
    use: [gke_cluster]

4- Blueprint deployed succesfully and verified by GCP Console only the new nodepool created with name like the sample name above

5- Destroyed the the cluster successfully

@sharabiani sharabiani added release-module-improvements Added to release notes under the "Module Improvements" heading. release-bugfix Added to release notes under the "Bug fixes" heading. labels Oct 11, 2024
@sharabiani sharabiani self-assigned this Oct 11, 2024
@mr0re1 mr0re1 removed their assignment Oct 12, 2024
@sharabiani sharabiani merged commit ea07fd6 into GoogleCloudPlatform:develop Oct 14, 2024
8 of 54 checks passed
@harshthakkar01 harshthakkar01 mentioned this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading. release-module-improvements Added to release notes under the "Module Improvements" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants