SlurmGCP. Relax reservation_name match, allow for suffix

[mr0re1]

Testing

# main.tf
variable "project_id" { default="var_P" }

variable "reservation_name" {
  type=string
  validation {
    condition     = length(regexall("^((projects/([a-z0-9-]+)/reservations/)?([a-z0-9-]+)(/[a-z0-9-]+/[a-z0-9-]+)?)?$", var.reservation_name)) > 0
    error_message = "Reservation name must be either empty or in the format '[projects/PROJECT_ID/reservations/]RESERVATION_NAME[/SUFF/IX]', [...] are optional parts."
  }
}

locals {
  res_match = regex("^(?P<whole>(?P<prefix>projects/(?P<project>[a-z0-9-]+)/reservations/)?(?<name>[a-z0-9-]+)(?P<suffix>/[a-z0-9-]+/[a-z0-9-]+)?)?$", var.reservation_name)
  
  res_short_name = local.res_match.name
  res_project = coalesce(local.res_match.project, var.project_id)
  res_prefix = coalesce(local.res_match.prefix, "projects/${local.res_project}/reservations/")
  res_suffix = local.res_match.suffix == null ? "" : local.res_match.suffix
  
  reservation_name = local.res_match.whole == null ? "" : "${local.res_prefix}${local.res_short_name}${local.res_suffix}"
}

output "got" {
  value = {
    short_name    = local.res_short_name
    project = local.res_project
    full_name = local.reservation_name
  }}

$ terraform apply -var="reservation_name="
got = {
  "full_name" = ""
  "project" = "var_P"
  "short_name" = tostring(null)
}

$ terraform apply -var="reservation_name=olaf"
got = {
  "full_name" = "projects/var_P/reservations/olaf"
  "project" = "var_P"
  "short_name" = "olaf"
}

$ terraform apply -var="reservation_name=olaf/one/two"
got = {
  "full_name" = "projects/var_P/reservations/olaf/one/two"
  "project" = "var_P"
  "short_name" = "olaf"
}

$ terraform apply -var="reservation_name=projects/he-he/reservations/olaf"
got = {
  "full_name" = "projects/he-he/reservations/olaf"
  "project" = "he-he"
  "short_name" = "olaf"
}

$ terraform apply -var="reservation_name=projects/he-he/reservations/olaf/one/two"
got = {
  "full_name" = "projects/he-he/reservations/olaf/one/two"
  "project" = "he-he"
  "short_name" = "olaf"
}


$ terraform apply -var="reservation_name=olaf/one"
╷
│ Error: Invalid value for variable
│
│   on main.tf line 3:
│    3: variable "reservation_name" {
│     ├────────────────
│     │ var.reservation_name is "olaf/one"
│
│ Reservation name must be in the format '[projects/PROJECT_ID/reservations/]RESERVATION_NAME[/SUFF/IX]', [...] are optional parts.
│
│ This was checked by the validation rule at main.tf:5,3-13.
╵

# Also fails:
$ terraform apply -var="reservation_name=projects/he-he/reservations/olaf/one"