-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Daos Example Blueprints to support adoption of TPG v6 #3172
Delete Daos Example Blueprints to support adoption of TPG v6 #3172
Conversation
ea2b2e8
to
629fac2
Compare
629fac2
to
cb0174f
Compare
cb0174f
to
5f24dc9
Compare
5f24dc9
to
2e9fde7
Compare
2e9fde7
to
f44a1d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taking a closer look, I see a few new files that need changing:
- modules/README.md (remove mentions of DAOS)
- examples/README.md (remove mentions of DAOS)
- examples/cae/cae-slurm-v5-legacy.yaml and examples/cae/cae-slurm.yaml
- change DAOS suggestions in commented out text to point to Parallelstore
- docs/image-building.md
- pkg/modulereader/metadata_legacy.go
Please create a separate task to review docs/network_storage.md
and update it with Parallelstore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. To confirm that no Parallelstore functionality was impacted, 3 integration tests succeeded
4804319
into
GoogleCloudPlatform:develop
This pr deletes the Daos example blueprints from the toolkit. The daos example blueprints make use of the external google cloud daos repository that pins the TPG version of the daos modules to version 4.84.0. In trying to upgrade the minimum TPG version used in the toolkit to 5.44.2, the daos example blueprints (which reference the daos modules with a pinned 4.84.0 TPG version) are a blockage.
With the deletion of the Daos example blueprints from the toolkit, we advise the preferable use of Parallelstore to have 1st party access to DAOS.
If the use of the external google cloud daos repository is necessary, we direct the use of the Cluster Toolkit version(1.41.0) in combination with the external google cloud daos repository.
Submission Checklist
NOTE: Community submissions can take up to 2 weeks to be reviewed.
Please take the following actions before submitting this pull request.