Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validation for global vars #32

Merged
merged 3 commits into from
Nov 12, 2021

Conversation

heyealex
Copy link
Contributor

@heyealex heyealex commented Nov 11, 2021

Add another validation stage for global vars where we validate that:

  • No vars are set to null (unset in YAML)
  • project_id is a global var (only warn if not)
  • labels are the correct type (as they are needed elsewhere)

In addition, a few minor changes where made in validate.go in handling
errors to keep consistency.

Submission Checklist:

  • Have you installed and run this change against pre-commit? pre-commit install
  • Are all tests passing? make tests
  • If applicable, have you written additional unit tests to cover this
    change?
  • Is unit test coverage still above 80%?
  • Have you updated any application documentation such as READMEs and user
    guides?
  • Have you followed the guidelines in our Contributing document?

Add another validation stage for global vars where we validate that:
* No vars are set to null (unset in YAML)
* project_id is a global var (only warn if not)
* labels are the correct type (as they are needed elsewhere)

In addition, a few minor changes where made in validate.go in handling
errors to keep consistency.
Add another validation stage for global vars where we validate that:
* No vars are set to null (unset in YAML)
* project_id is a global var (only warn if not)
* labels are the correct type (as they are needed elsewhere)

In addition, a few minor changes where made in validate.go in handling
errors to keep consistency.
@heyealex heyealex merged commit b8da3a3 into GoogleCloudPlatform:develop Nov 12, 2021
@heyealex heyealex deleted the check-for-null-project branch November 12, 2021 16:48
ek-nag added a commit to nagconsulting/hpc-toolkit that referenced this pull request May 2, 2024
…ng-clusters-permissions

OFE fix: ps-connect, go location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants