Gke update default taints for user node pools #3200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankitkinra
added
the
release-improvements
chengcongdu
reviewed
Oct 31, 2024
ankitkinra
changed the title
…rately when required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the default user node pool taint of "user-workload" allows the user workloads jobs to land on the GPU node pools without adding tolerations to all user jobs.
Default taint was added to user node pools to prevent non GPU workloads from landing there.
However, GKE adds a
gputaint already to GPU nodepools https://cloud.google.com/kubernetes-engine/docs/how-to/gpus#taint which makes these taints redundant and complicate user workflows.