Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify providing additional_networks for Slurm nodesets #3303

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Simplify providing additional_networks for Slurm nodesets #3303

merged 1 commit into from
Dec 3, 2024
+13 −13

Conversation

wiktorn
Copy link
Contributor

@wiktorn wiktorn commented Nov 24, 2024

Simplify definition of additional_networks, before the change one had to write for example

           additional_networks:
             - network: ""
               subnetwork: $(network2.subnetwork_self_link)
               subnetwork_project: ""
               network_ip: ""
               nic_type: VIRTIO_NET
               stack_type: ""
               queue_count: null
               access_config: []
               ipv6_access_config: []
               alias_ip_range: []

Now its possible to write just:

          additional_networks:
            - subnetwork: $(network2.subnetwork_self_link)
              nic_type: VIRTIO_NET

@wiktorn wiktorn changed the title Make most of the variables optional on additional networks to reduce … Simplify providing additional_networks for Slurm nodesets Nov 24, 2024
@mr0re1 mr0re1 self-requested a review November 27, 2024 02:48
@mr0re1 mr0re1 self-assigned this Nov 27, 2024
@mr0re1 mr0re1 assigned wiktorn and unassigned mr0re1 Dec 3, 2024
@mr0re1
Copy link
Collaborator

mr0re1 commented Dec 3, 2024

/gcbrun

@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 3, 2024
@wiktorn wiktorn force-pushed the simplify_additional_networks branch from 6d254be to 46d2c3d Compare December 3, 2024 05:26
@wiktorn wiktorn assigned mr0re1 and unassigned wiktorn Dec 3, 2024
@mr0re1
Copy link
Collaborator

mr0re1 commented Dec 3, 2024

/gcbrun

@mr0re1 mr0re1 merged commit f032613 into GoogleCloudPlatform:develop Dec 3, 2024
8 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mr0re1 mr0re1 mr0re1 approved these changes

Assignees

@mr0re1 mr0re1

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wiktorn @mr0re1