Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlurmGCP. Refactor instance grouping #3332

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Dec 3, 2024

Refactor bulk-grouping of nodes and improve obtaining "resume_data":

  • Delete unused post_main_resume_nodes plugin support;
  • Refactor group_nodes_bulk as preparation for future behavior changes;
  • Remove global global_resume_data;
  • Add caching to to_hostnames;
  • Reduce calls to to_hostnames;
  • Use dataclass instead of NSDict;
  • Add unit tests;

Motivation:
Current (before & after change) implementation of group_nodes_bulk is very complex. This is an attempt to deliver changes that don't affect behavior + add test coverage before working on follow up PR that will deliver behavioral changes.

@mr0re1 mr0re1 self-assigned this Dec 3, 2024
@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 3, 2024
@mr0re1 mr0re1 requested a review from alyssa-sm December 3, 2024 20:07
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Dec 3, 2024
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Dec 3, 2024
@mr0re1 mr0re1 merged commit f7161e8 into GoogleCloudPlatform:develop Dec 4, 2024
24 of 57 checks passed
@mr0re1 mr0re1 deleted the resume_data branch December 4, 2024 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants