SlurmGCP. Refactor instance grouping #3332
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor bulk-grouping of nodes and improve obtaining "resume_data":
post_main_resume_nodes
plugin support;group_nodes_bulk
as preparation for future behavior changes;global_resume_data
;to_hostnames
;to_hostnames
;dataclass
instead ofNSDict
;Motivation:
Current (before & after change) implementation of
group_nodes_bulk
is very complex. This is an attempt to deliver changes that don't affect behavior + add test coverage before working on follow up PR that will deliver behavioral changes.