Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SlurmGCP. Improve resume.py performance for job arrays. #3340

Merged
merged 1 commit into from
Dec 5, 2024
Merged

SlurmGCP. Improve resume.py performance for job arrays. #3340

merged 1 commit into from
Dec 5, 2024
+106 −119

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Dec 4, 2024 •
edited
Loading

  • Don't group nodes creation by non-exclusive jobs;
  • Fix a bug, when multiple non-placements nodesets can not be provisioned due to overwrite by key (placement == None).

@mr0re1 mr0re1 self-assigned this Dec 4, 2024
@mr0re1 mr0re1 requested a review from alyssa-sm December 4, 2024 20:56
@mr0re1 mr0re1 assigned alyssa-sm and unassigned mr0re1 Dec 4, 2024
@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 4, 2024
@alyssa-sm alyssa-sm assigned mr0re1 and unassigned alyssa-sm Dec 4, 2024
@alyssa-sm
Copy link
Contributor

Approval with tests passing

@mr0re1 mr0re1 merged commit 5f1092e into GoogleCloudPlatform:develop Dec 5, 2024
23 of 57 checks passed
@mr0re1 mr0re1 deleted the job_array branch December 5, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alyssa-sm alyssa-sm alyssa-sm approved these changes

Assignees

@mr0re1 mr0re1

Labels
release-chore To not include into release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mr0re1 @alyssa-sm