Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set 'enable_private_endpoint' to false #3364

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

pawloch00
Copy link
Contributor

@pawloch00 pawloch00 commented Dec 9, 2024

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.
Set enable_private_endpoint to false, so cluster do not fail during creation.
Right now, buidling gke a3 mega blueprint fails with error:
Error: Error waiting for creating GKE cluster: Invalid master authorized networks: network "x.y.z.w/l" is not a reserved network, which is required for private endpoints.

With enable_private_endpoint set to false user can access cluster either with private or public endpoint.
It looks like this was introduced here c901563
Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@pawloch00 pawloch00 added the release-bugfix Added to release notes under the "Bug fixes" heading. label Dec 9, 2024
Copy link
Contributor

@ankitkinra ankitkinra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add to the description of the CLs two things:

  • Why is enable_private_endpoint is important ?
  • That currently this blueprint is broken

@annuay-google annuay-google self-requested a review December 10, 2024 11:16
@annuay-google annuay-google self-assigned this Dec 10, 2024
@pawloch00 pawloch00 merged commit 09f4b0c into GoogleCloudPlatform:develop Dec 11, 2024
10 of 64 checks passed
@pawloch00 pawloch00 deleted the ppawl-fix-a3-xpk branch December 11, 2024 17:19
@nick-stroud nick-stroud mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-bugfix Added to release notes under the "Bug fixes" heading.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants