New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix node_is_fr to handle empty string instead #3369

Merged

abbas1902 merged 1 commit into GoogleCloudPlatform:develop from abbas1902:fr_fix

Dec 9, 2024

Contributor

abbas1902 commented Dec 9, 2024

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

Fork your PR branch from the Toolkit "develop" branch (not main)
Test all changes with pre-commit in a local branch #
Confirm that "make tests" passes all tests
Add or modify unit tests to cover code changes
Ensure that unit test coverage remains above 80%
Update all applicable documentation
Follow Cluster Toolkit Contribution guidelines #

abbas1902 added the release-chore label


          Fix node_is_fr to handle empty string instead

f774aa9

abbas1902 force-pushed the fr_fix branch from 3ce09c3 to f774aa9 Compare

December 9, 2024 23:47

mr0re1 approved these changes

View reviewed changes

abbas1902 enabled auto-merge

December 9, 2024 23:48

abbas1902 merged commit ef29fd7 into GoogleCloudPlatform:develop

8 of 61 checks passed

abbas1902 deleted the fr_fix branch

December 10, 2024 00:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels