Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate instance_template modules from slurm-gcp repo #3380

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Dec 10, 2024

Move modules slurm_instance_template and _instance_template
from slurm-gcp/tree/master/terraform/slurm_cluster/modules
to community/modules/internal/slurm-gcp-v6.

Based on master branch at GoogleCloudPlatform/slurm-gcp@740472d

Non-breaking change, no need for moved-block, terraform and resource addressing is preserved completely.

Followup actions:

  • Merge modules instance_template and internal_instance_template into one, currently blocked by google_compute_instance_template bug (to be reported);

  • Lint and update license of community/modules/internal/slurm-gcp-v6/instance_template/files/startup_sh_unlinted (preserved unchanged to avoid drift).

@mr0re1 mr0re1 requested a review from abbas1902 December 10, 2024 21:22
@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 10, 2024
@abbas1902 abbas1902 assigned mr0re1 and unassigned abbas1902 Dec 10, 2024
@mr0re1 mr0re1 merged commit d3f3ceb into GoogleCloudPlatform:develop Dec 10, 2024
18 of 61 checks passed
@mr0re1 mr0re1 deleted the move_tmpl2 branch December 10, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants