Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip setting disk_labels if disk_type is local-ssd #3383

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

abbas1902
Copy link
Contributor

@abbas1902 abbas1902 commented Dec 10, 2024

Before when redeploying running instance with local-ssd with no labels:

~/cluster-toolkit$ ./gcluster deploy hpc-slurm/
Testing if deployment group hpc-slurm/primary requires adding or changing cloud infrastructure
Deployment group hpc-slurm/primary requires adding or changing cloud infrastructure
Summary of proposed changes: Plan: 1 to add, 1 to change, 1 to destroy.

After:

~/cluster-toolkit$ ./gcluster deploy hpc-slurm/
Testing if deployment group hpc-slurm/primary requires adding or changing cloud infrastructure
Cloud infrastructure in deployment group hpc-slurm/primary is already applied
Collecting terraform outputs from hpc-slurm/primary
Deployment group primary contains no artifacts to export

###############################
Find instructions for cleanly destroying infrastructure and advanced manual
deployment instructions at:

hpc-slurm/instructions.txt

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@abbas1902 abbas1902 requested a review from mr0re1 December 10, 2024 23:10
@abbas1902 abbas1902 added the release-chore To not include into release notes label Dec 10, 2024
@mr0re1 mr0re1 assigned abbas1902 and unassigned mr0re1 Dec 10, 2024
@abbas1902 abbas1902 merged commit 5f4bb52 into GoogleCloudPlatform:develop Dec 11, 2024
12 of 63 checks passed
@abbas1902 abbas1902 deleted the labels_ssd branch December 11, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants