Adding network_profile to the VPC modules #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdunbar13
added
the
release-module-improvements
cdunbar13
force-pushed
the
vpc-network-profile
branch
from
460c641 to
54cb64c
Compare
cdunbar13
force-pushed
the
vpc-network-profile
branch
from
54cb64c to
d474219
Compare
cdunbar13
force-pushed
the
vpc-network-profile
branch
from
d474219 to
4351862
Compare
tpdownes
approved these changes
Dec 12, 2024
cdunbar13
merged commit e7dae4e
into
GoogleCloudPlatform:develop
45 of 62 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CFT module has updated (pending) to include the network-profile setting. This PR adds that setting to the VPC and Multi-VPC modules.
Running against a number of the integration tests.