Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SlurmGCP. Move source_image_logic down to template module #3455

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mr0re1
Copy link
Collaborator

@mr0re1 mr0re1 commented Dec 21, 2024

  • Move source_image_logic down to template module;
  • Simplify interface between instance_template and internal_instance_template;
  • Simplify some redundant terraform.

Motivation: unify interfaces and move "sanitization" down as a preparation for new version of Slurm modules.

@mr0re1 mr0re1 added the release-chore To not include into release notes label Dec 21, 2024
@mr0re1 mr0re1 requested a review from abbas1902 December 21, 2024 20:18
@mr0re1 mr0re1 assigned abbas1902 and mr0re1 and unassigned abbas1902 Dec 21, 2024
@mr0re1 mr0re1 marked this pull request as draft December 22, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-chore To not include into release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants