Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in hpc-cluster-slurm.yaml #4

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Fix bug in hpc-cluster-slurm.yaml #4

merged 6 commits into from
Oct 15, 2021

Commits on Oct 15, 2021

  1. Fix bug in hpc-cluster-slurm.yaml 

    Default values for terraform variables have been taking precedence over
global variables, so the default for the login-node was taken rather
than the global variable, unlike the controller which had not default
set.

To remedy this:
* The default was removed from zone for the login node
* Precendence has been modified to pull from globals before defaults

In addition to this, a few other fixes have been included:
* Updating the omnia branch name to include the version
* Better error handling in the expand step
* Tests to cover new behavior in applyGlobalVariables
    @heyealex
    heyealex committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    a7c377e View commit details
    Browse the repository at this point in the history

  2. Improve flow when checking for global variables 

    This commit creates a more explicit flow showing the precedence for
sourcing a setting from explicit to global to default, and failing if it
can't be found anywhere. Updating tests to reflect this as well.
    @heyealex
    heyealex committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    2c8bcb7 View commit details
    Browse the repository at this point in the history

  3. Minor updates to prepare for internal mirror 

    Moved templates from their own directory to within reswriter as is
required by internal embed tooling and removed a test that is not
properly self-contained.
    @heyealex
    heyealex committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d5981b1 View commit details
    Browse the repository at this point in the history

  4. linter fixes for go and terraform (#2) 

    * linter fixes for go and terraform

Adding package comments and various other go-lint related fixes. This
also updates the python script for omnia install and fixes an outdated
branch name for omnia.
    @heyealex
    heyealex committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    b7cc78a View commit details
    Browse the repository at this point in the history

  5. Remove redundant package comments

    @heyealex
    heyealex committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    d9bea18 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'GoogleCloudPlatform:develop' into bugfix/hpc-slurm-zone… 

    …-mismatch
    @heyealex
    heyealex authored Oct 15, 2021
    Configuration menu
    Copy the full SHA
    7bcb56e View commit details
    Browse the repository at this point in the history