Add dashboard monitoring resources #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a resources that creates a monitoring dashboard based on a json.tpl file. The dashboards can be customized with widgets that may eventually be outputs from other resources and can be setup to filter by deployment_name. Also includes two default dashboard JSON files: * Empty: empty with the exception of a text box * HPC: HPC focused dashboard
heyealex
force-pushed
the
monitoring-dashboard
branch
from
2843384
to
88e9903
Compare
cboneti
approved these changes
Dec 2, 2021
| } | ||
|
|
||
| variable "base_dashboard" { | ||
| description = "Baseline dashboard template, either custom or from ./dashboards" |
There was a problem hiding this comment.
so, what are the options here? a path?
does that mean I can add ~/my-dash.json?
|
Addressed the feedback in the last commit. I also added "title" as a variable and set the default text boxes to that and the title of the dashboard to "title: deployment_name" to make it more flexible overall. |
cboneti
approved these changes
Dec 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a resources that creates a monitoring dashboard based on a
json.tpl file. The dashboards can be customized with widgets that may
eventually be outputs from other resources and can be setup to filter by
deployment_name.
Also includes two default dashboard JSON files:
Submission Checklist:
pre-commit installmake testschange?
guides?